anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit 
logging in ZooKeeper servers.
URL: https://github.com/apache/zookeeper/pull/1133#discussion_r343102884
 
 

 ##########
 File path: 
zookeeper-server/src/main/java/org/apache/zookeeper/audit/Log4jAuditLogger.java
 ##########
 @@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zookeeper.audit;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Log4j based audit logger
+ */
+public class Log4jAuditLogger implements AuditLogger {
+    private static final Logger LOG = 
LoggerFactory.getLogger(Log4jAuditLogger.class);
+
+    @Override
+    public void logAuditEvent(AuditEvent auditEvent) {
+        if 
(AuditConstants.FAILURE.equals(auditEvent.getValue(AuditEvent.FieldName.RESULT)))
 {
 
 Review comment:
   If RESULT is a mandatory field of an `AuditEvent`, it should be a member 
field instead of adding it to the Map. In which case we could replace this part 
with a single field comparison.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to