lvfangmin commented on a change in pull request #1059: [ZOOKEEPER-3512] Real 
time data consistency check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#discussion_r355200253
 
 

 ##########
 File path: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileSnap.java
 ##########
 @@ -78,15 +78,17 @@ public long deserialize(DataTree dt, Map<Long, Integer> 
sessions) throws IOExcep
             return -1L;
         }
         File snap = null;
+        long snapZxid = 0;
 
 Review comment:
   There is no correctness issue with 0, but I'll change it to -1 to make it 
identical with the default returned from Util.getZxidFromName.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to