eolivelli commented on a change in pull request #1251: ZOOKEEPER-3720: Fix
rolling upgrade failure (invalid protocol version)
URL: https://github.com/apache/zookeeper/pull/1251#discussion_r378436446
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
##########
@@ -113,9 +115,12 @@
private AtomicLong observerCounter = new AtomicLong(-1);
/*
- * Protocol identifier used among peers
+ * Protocol identifier used among peers (must be a negative number for
backward compatibility reasons)
*/
- public static final long PROTOCOL_VERSION = -65535L;
+ // the following protocol version was sent in every connection initiation
message since ZOOKEEPER-2186 released in 3.4.7
+ public static final long PROTOCOL_VERSION_3_4_7 = -65536L;
Review comment:
I would call this constant PROTOCOL_VERSION_V1
and the other one PROTOCOL_VERSION_V2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
