maoling commented on issue #1257: ZOOKEEPER-3652: Synchronize ClientCnxn outgoing queue flush on a stable internal value URL: https://github.com/apache/zookeeper/pull/1257#issuecomment-590867118 @swallez - `[ERROR] Synchronization performed on java.util.concurrent.LinkedBlockingDeque in org.apache.zookeeper.ClientCnxn.queuePacket(RequestHeader, ReplyHeader, Record, Record, AsyncCallback, String, String, Object, ZooKeeper$WatchRegistration, WatchDeregistration) [org.apache.zookeeper.ClientCnxn] At ClientCnxn.java:[line 1645] ` - JLM_JSR166_UTILCONCURRENT_MONITORENTER: This method performs synchronization an object that is an instance of a class from the java.util.concurrent package (or its subclasses). Instances of these classes have their own concurrency control mechanisms that are orthogonal to the synchronization provided by the Java keyword synchronized. For example, synchronizing on an AtomicBoolean will not prevent other threads from modifying the AtomicBoolean. Such code may be correct, but should be carefully reviewed and documented, and may confuse people who have to maintain the code at a later date.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
