eolivelli commented on a change in pull request #1235: ZOOKEEPER-3706:
ZooKeeper.close() would leak SendThread when the netw…
URL: https://github.com/apache/zookeeper/pull/1235#discussion_r385524422
##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
##########
@@ -1428,7 +1447,10 @@ void onConnected(
}
void close() {
- state = States.CLOSED;
+ try {
+ changeZkState(States.CLOSED);
+ } catch (IOException e) {
Review comment:
Please add a comment
We could anyway spend a line of log, thus case won't happen but if it is
happening we won't know
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
