symat opened a new pull request #1274: ZOOKEEPER-3740: fix flaky 
PurgeTxnTest.testPurgeWhenLogRollingInProgress
URL: https://github.com/apache/zookeeper/pull/1274
 
 
   This test is always passing for me when I execute only the PurgeTxnTest test 
   class locally, but when I execute all the tests (with multiple parallel 
threads, 
   using `mvn clean install`), then it always fails. It is failing frequently on
   the `zookeeper-master-maven` Jenkins job as well.
   
   The test starts three threads, performing 1000 ZNode creation in each thread
   and timeouts if the threads are not finished in 90 seconds. Currently it is
   not easy to tell based on the logs if the timeout happens because the
   operations are still in progress or if one of the threads terminated due
   to an unexpected exception.
   
   In this patch I:
   - increased the timeout from 90 to 120 seconds
   - added an extra logic to actually fail because of the Exception on the
   threads, if any happen during the execution
   - I decreased the number of ZNode creations to 750 (from the original 1000)
   
   Applying this patch locally fixed my issues, I hope it will be enough
   to fix the test on Jenkins as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to