eolivelli commented on a change in pull request #1304: ZOOKEEPER-3780 - restore
Version.getRevision() to be bacward compatible
URL: https://github.com/apache/zookeeper/pull/1304#discussion_r402162356
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/version/util/VerGen.java
##########
@@ -84,6 +84,7 @@ public static void generateFile(File outputDir, Version
version, String rev, Str
if (rev.equals("-1")) {
System.out.println("Unknown REVISION number, using " + rev);
}
+ w.write(" int REVISION=-1; //@deprecated, will be removed in
3.7.0\n");
Review comment:
Don't claim it to be removed in a specific version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services