symat commented on a change in pull request #1301: ZOOKEEPER-3774: Close quorum
socket asynchronously on the leader to a…
URL: https://github.com/apache/zookeeper/pull/1301#discussion_r410023981
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
##########
@@ -63,12 +65,21 @@
private static final Logger LOG =
LoggerFactory.getLogger(LearnerHandler.class);
+ public static final String LEADER_CLOSE_SOCKET_ASYNC =
"leader.closeSocketAsync";
+ public static final boolean closeSocketAsync =
Boolean.parseBoolean(System.getProperty(LEADER_CLOSE_SOCKET_ASYNC, "true"));
Review comment:
please set the default value to false (as you also indicated in the docs)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services