ctubbsii commented on a change in pull request #1359:
URL: https://github.com/apache/zookeeper/pull/1359#discussion_r428645551
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/common/StringUtils.java
##########
@@ -48,6 +48,12 @@ private StringUtils() {/** non instantiable and non
inheritable **/}
* into a single string, where the original strings are separated using
* the given delimiter.
*
+ * Deprecated. Use {@link String#join(CharSequence, CharSequence...)}
Review comment:
This should be a proper javadoc deprecated tag, something liike:
```java
/**
* @deprecated since ZK version ... Use {@link ....} instead.`
*/
```
And, the method should have a `@Deprecated` Java annotation. Any build
warnings can be suppressed by updating any calling code to suppress the warning
or use its replacement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
