symat commented on a change in pull request #1407:
URL: https://github.com/apache/zookeeper/pull/1407#discussion_r459380552
##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
##########
@@ -589,6 +600,8 @@ private void processEvent(Object event) {
((AsyncCallback.EphemeralsCallback)
lcb.cb).processResult(lcb.rc, lcb.ctx, null);
} else if (lcb.cb instanceof
AsyncCallback.AllChildrenNumberCallback) {
((AsyncCallback.AllChildrenNumberCallback)
lcb.cb).processResult(lcb.rc, lcb.path, lcb.ctx, -1);
+ } else if (lcb.cb instanceof AsyncCallback.MultiCallback) {
Review comment:
at the first glance, it makes sense for me... AFAICT: if the client
would like to execute an "empty" multiop request, we just return immediately
without even sending the request to the server.
@eolivelli Do you think we would need to implement the similar logic for the
C-client? (I see we have `TestMulti.cc` with a few unit tests, but don't see
any test for empty multi-request. Also I don't see in the c code that this
specific case would be handled in the C client.) I think adding a new unit test
for the C-client (and potentially make a fix) would make sense. Or at least
register a follow-up jira for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
