symat commented on a change in pull request #1417:
URL: https://github.com/apache/zookeeper/pull/1417#discussion_r462946600
##########
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/RemoveWatchesTest.java
##########
@@ -82,15 +84,10 @@ public void tearDown() throws Exception {
super.tearDown();
}
- private final boolean useAsync;
-
- public RemoveWatchesTest(boolean useAsync) {
- this.useAsync = useAsync;
- }
-
- @Parameters
- public static Collection<Object[]> configs() {
- return Arrays.asList(new Object[][]{{false}, {true}});
+ public static Stream<Arguments> data() throws Exception {
Review comment:
for these trivial test parameter wouldn't be nicer to use `@ValueSource`
instead of `@MethodSource` ?
see: https://www.baeldung.com/parameterized-tests-junit-5#1-simple-values
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
