ztzg commented on pull request #1525: URL: https://github.com/apache/zookeeper/pull/1525#issuecomment-723911040
Looking at [the Jenkins log](https://ci-hadoop.apache.org/blue/organizations/jenkins/zookeeper-precommit-github-pr/detail/PR-1525/2/pipeline#step-35-log-1094 ), I see some `checkstyle` errors. You should be able to reproduce locally by running something akin to: mvn checkstyle:check -Pfull-build You will then see a report for validations such as the following: [ERROR] […]/ReadOnlyZooKeeperServerTest.java:3: Using the '.*' form of import should be avoided - org.apache.zookeeper.server.*. [AvoidStarImport] [ERROR] […]/ReadOnlyZooKeeperServerTest.java:5: Extra separation in import group before 'org.apache.zookeeper.server.persistence.FileTxnSnapLog' [ImportOrder] [ERROR] […]/ReadOnlyZooKeeperServerTest.java:8: Extra separation in import group before 'java.nio.ByteBuffer' [ImportOrder] […] Looking at [the Travis log](https://travis-ci.org/github/apache/zookeeper/jobs/741862504), I see two file missing license headers: [WARNING] Files with unapproved licenses: /home/travis/build/apache/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/TestServerCnxn.java /home/travis/build/apache/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServerTest.java [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.13:check (default-cli) on project zookeeper: Too many files with unapproved license: 2 See RAT report in: /home/travis/build/apache/zookeeper/zookeeper-server/target/rat.txt -> [Help 1] I would just copy the Apache license banner from one of the existing files. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
