ctubbsii commented on a change in pull request #1532:
URL: https://github.com/apache/zookeeper/pull/1532#discussion_r521784326
##########
File path: bin/zkEnv.sh
##########
@@ -120,6 +120,7 @@ for d in "$ZOOBINDIR"/../zookeeper-server/target/lib/*.jar
do
CLASSPATH="$d:$CLASSPATH"
done
+export CLASSPATH
Review comment:
Behaviorally, I don't think it matters, but stylistically, it always
seemed to me that it would be best to export after making all assignments.
There's a few lines below that still assign `CLASSPATH` to another value.
However, I don't think it matters, because I just did a quick test with two
bash scripts, and it seems like if you export and then assign it a new value,
the exported value is the new value, even if it was assigned after the export
statement. I don't know if that works in all cases, though.
In any case, I still think it's good style to export after all assignments,
rather than after some and before others.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
