lvisterin commented on pull request #1524: URL: https://github.com/apache/zookeeper/pull/1524#issuecomment-725991120
>however today I noticed the same issue appearing in Leader.java 's createServerSocket I have not been able to repro this one, but identified it is most likely caused by an issue on our DNS where the response flips between bad and good IP addresses (due to consistency issues). That way it was able to pass this fixed part, land in that other piece of code, and break again. The problem was that at that point things were so messed up that there are many other issues so a simple fix there does not help. Therefore I believe this PR is sufficient to make Zookeeper more resilient for users with a laggy DNS, and in cases where the DNS gives a random mix of good and bad replies it is better fixed on the user's side instead (which I did on my end). So for me this is good to be merged if you agree. Thanks for the review! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
