eolivelli commented on a change in pull request #1526:
URL: https://github.com/apache/zookeeper/pull/1526#discussion_r526663543
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
##########
@@ -611,14 +611,16 @@ public void rollLog() throws IOException {
* @throws IOException
*/
public void close() throws IOException {
Review comment:
@hanm thanks for your review.
This little change is because during a graceful shutdown there is a race
condition and multiple threads are going to call this method and we hit a
NullPointerException that is usually harmless but it is very scary to see in
the logs.
I hope you are fine with it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
