arshadmohammad commented on a change in pull request #1681:
URL: https://github.com/apache/zookeeper/pull/1681#discussion_r611642449
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java
##########
@@ -520,6 +520,9 @@ private void receiveMessage(ByteBuf message) {
if (len < 0 || len > BinaryInputArchive.maxBuffer) {
throw new IOException("Len error " + len);
}
+ if (zkServer == null || !zkServer.isRunning()) {
+ throw new IOException("ZK down");
+ }
Review comment:
sorry I missed in previous review, I think it is better to handle the
same way as it is handled in `NIOServerCnxn` to be consistent with all types of
connections
```
if (!isZKServerRunning()) {
throw new IOException("ZooKeeperServer not running");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
