rvaleti commented on pull request #1684: URL: https://github.com/apache/zookeeper/pull/1684#issuecomment-819345168
Hi @symat I raised a PR for master branch as suggested. I did spend a lot of time on trying to add a test for this. Inducing a sleep in to ClientCnxn#SendThread#startConnect() or ZookeeperSaslClient was not feasible. We have to do a lot of refactoring in order to get there. - expose ZookeeperSaslClient so that it can be mocked/extended - or make sendThread non-final so it can be overridden from test and then induce a pause. Please let me know if there's an easy way out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
