[GitHub] [zookeeper] Shoothzj commented on pull request #1574: ZOOKEEPER-4054: Make prometheus listen host can configure

[GitBox]

Shoothzj commented on pull request #1574:
URL: https://github.com/apache/zookeeper/pull/1574#issuecomment-841955752


   > @Shoothzj The CI failure was caused by this PR, please take a look
   > 
   > ```
   > diff --git 
a/zookeeper-server/src/test/resources/data/invalidsnap/version-2/snapshot.83f 
b/zookeeper-server/src/test/resources/data/invalidsnap/version-2/snapshot.83f
   > deleted file mode 100644
   > index 26dc5f665..000000000
   > Binary files 
a/zookeeper-server/src/test/resources/data/invalidsnap/version-2/snapshot.83f 
and /dev/null differ
   > 
   > [ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
1.072 s <<< FAILURE! - in org.apache.zookeeper.test.InvalidSnapshotTest
   > [ERROR] testSnapshotFormatterWithInvalidSnap  Time elapsed: 0.034 s  <<< 
FAILURE!
   > org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
   >    at 
org.apache.zookeeper.test.InvalidSnapshotTest.testSnapshotFormatterWithInvalidSnap(InvalidSnapshotTest.java:81)
   > ```
   
   
   @maoling 
   Fixed the tests.
   
   I am sorry for my careless. The mistake must be introduced by 
running、debuging tests. And github fold the binary file..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org