brentwritescode opened a new pull request #1796: URL: https://github.com/apache/zookeeper/pull/1796
Apache Jira Issue: https://issues.apache.org/jira/browse/ZOOKEEPER-4291 Zookeeper Contribution Guidelines: https://cwiki.apache.org/confluence/display/zookeeper/howtocontribute This is a fairly substantial change and I will also send a note on the zookeeper-dev@ mailing list to start a discussion in case there are more questions/comments. The existing version of ZooInspector had an extremely short cache retention time combined with tying high frequency UI operations to network calls which resulted in almost unusable latency when using ZooInspector to talk to a Zookeeper cluster over a network. This change refactors the tree view to move network calls onto background threads in the TreeModel while keeping the UI itself responsive and only reloading data on request after initial node expansion. In general, I think these changes take the tool from being virtually unusable when talking to remote clusters to being performant enough and responsive enough to be useful in most cases. Some other related highlights include: - Made getNumChildren() use the NodeCache (it wasn't previously) - Remove network calls getting triggered during UI redraw animations such as using scroll bars or resizing the window - Addition of a mouse spinner animation when work is in progress - Addition of the number of child nodes in parentheses after the node name on the UI - Move Add/Delete node logic to be encapsulated in TreeViewer logic (and remove separate Add/Delete NodeAction classes) - Addition of a right-click menu item to refresh a selected subtree (previously this was only doable for the entire tree) - Fixed the broken "Node Viewer Settings" icon and button (it previously had no icon set and didn't show on the UI) - Fixed the broken "About" button (it previously was failing to find the about.html file) - Fixed a number of Javadoc-related build warnings - Fixed a number of naming typos (e.g. NodeVeiwers -> NodeViewers) - Removed some dead/unused code Testing - The build succeeds, though ZooInspector currently has no unit tests. I did test it fairly extensively with some remote clusters I have available. <img width="974" alt="zooinspector-helix-screenshot" src="https://user-images.githubusercontent.com/33364712/148818936-065d19fc-e06b-4b00-8cae-374cd8ac82a0.png";> I have attached a screenshot of the updated version of ZooInspector (examining an Apache Helix cluster in Zookeeper). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
![https://user-images.githubusercontent.com/33364712/148818936-065d19fc-e06b-4b00-8cae-374cd8ac82a0.png"](https://user-images.githubusercontent.com/33364712/148818936-065d19fc-e06b-4b00-8cae-374cd8ac82a0.png"){kind=link}