ctubbsii commented on pull request #1802: URL: https://github.com/apache/zookeeper/pull/1802#issuecomment-1027018960
> > Yes. In general, ZK should exclude any logging runtimes coming from dependencies using , and it should mark any logging runtimes it adds as true. This would be very helpful for downstream Maven builds that depend on ZK. > > 100% agreed. The real problem is that we don't have a clean "client package", I started to work on it much time ago, but I never finished. I'm not sure what you mean by `clean "client package"` or how that applies here. > > But this is actually out of the scope of the PR. isn't it ? I'm not so sure. In order to ensure slf4j binds to reload4j and not to log4j1, you probably need to make sure any log4j1 jars are excluded from the classpath. That means doing the work to set up any exclusions from dependencies. That can be made easier by checking the dependency hierarchy with `mvn dependency:tree`. Declaring reload4j as optional might be considered out of scope, but it's also trivial to do, so I'd include it anyway, so long as it doesn't prevent it from being bundled in the distribution assembly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
