tisonkun commented on code in PR #1820:
URL: https://github.com/apache/zookeeper/pull/1820#discussion_r908656704
##########
zookeeper-server/src/main/java/org/apache/zookeeper/ZKWatchManager.java:
##########
@@ -442,10 +442,13 @@ public Set<Watcher> materialize(
return result;
}
- private void addPersistentWatches(String clientPath, Set<Watcher> result) {
+ private void addPersistentWatches(String clientPath,
Watcher.Event.EventType type, Set<Watcher> result) {
synchronized (persistentWatches) {
addTo(persistentWatches.get(clientPath), result);
}
+ if (type == Watcher.Event.EventType.NodeChildrenChanged) {
Review Comment:
A comment about reason to filter `NodeChildrenChanged` event helps - it's
not quite straightforward.
##########
zookeeper-server/src/test/java/org/apache/zookeeper/test/PersistentRecursiveWatcherTest.java:
##########
@@ -114,6 +114,23 @@ public void testRemoval()
}
}
+ @Test
+ public void testNoChildEvents() throws Exception {
+ try (ZooKeeper zk = createClient()) {
+ zk.create("/a", new byte[0], ZooDefs.Ids.OPEN_ACL_UNSAFE,
CreateMode.PERSISTENT);
+
+ zk.addWatch("/", persistentWatcher, PERSISTENT_RECURSIVE);
+
+ zk.getChildren("/a", true);
+
+ zk.create("/a/b", new byte[0], ZooDefs.Ids.OPEN_ACL_UNSAFE,
CreateMode.PERSISTENT);
+ zk.create("/a/b/c", new byte[0], ZooDefs.Ids.OPEN_ACL_UNSAFE,
CreateMode.PERSISTENT);
+
+ assertEvent(events, Watcher.Event.EventType.NodeCreated, "/a/b");
+ assertEvent(events, Watcher.Event.EventType.NodeCreated, "/a/b/c");
Review Comment:
You may assert no outstanding event here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
