symat commented on PR #1898: URL: https://github.com/apache/zookeeper/pull/1898#issuecomment-1181614447
Thank you @luke-sterkowicz for the contribution!! I re-triggered the CI, but don't worry about it (you were hitting a known flaky test, it is unrelated to your PR) > Introduce registerShutdownHook config flag (defaults to false) for backward compatibility. I'm not totally sure this parameter is required. Backward compatibility is important, but I don't think anyone relied on the fact that ZooKeeper haven't responded to SIGTERM signals before. @eolivelli , @anmolnar , what do you think? Anyway, if we introduce the parameter, then please document it in the admin guide: https://github.com/apache/zookeeper/blob/master/zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md Thanks!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
