tisonkun commented on code in PR #1905:
URL: https://github.com/apache/zookeeper/pull/1905#discussion_r923043534
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/ContainerManager.java:
##########
@@ -129,8 +128,8 @@ public void checkContainers() throws InterruptedException {
for (String containerPath : getCandidates()) {
long startMs = Time.currentElapsedTime();
- ByteBuffer path = ByteBuffer.wrap(containerPath.getBytes(UTF_8));
- Request request = new Request(null, 0, 0,
ZooDefs.OpCode.deleteContainer, path, null);
+ DeleteTxn txn = new DeleteTxn(containerPath);
+ Request request = new Request(null, 0, 0,
ZooDefs.OpCode.deleteContainer, RequestRecord.fromRecord(txn), null);
Review Comment:
Well. The serialization logics are different from Jute's string and UTF-8
string. This can make it impossible rolling update as new server send new
DeleteTxn but old server cannot recognize it.
Pending to revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
