li4wang commented on PR #1942: URL: https://github.com/apache/zookeeper/pull/1942#issuecomment-1308116154
The test failure `ConnectionMetricsTest.testRevalidateCount` is related to the changes in this PR. ` int follower1 = (int) util.getFollowerQuorumPeers().get(0).getId()` The test calls getId() to get the server id. Since getId() was changed to getMyId, the super class Thread.getId() is called and the thread id was returned. There is no corresponding peer associated to the thread id, that's why NPE is thrown. The test passed after changing getId() to getMyId(). I will open a JIRA to check in the fix. It would great if @eolivelli can do a quick review and get it merged. Thanks. https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/test/java/org/apache/zookeeper/server/ConnectionMetricsTest.java#L60-L65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
