anmolnar commented on code in PR #1943: URL: https://github.com/apache/zookeeper/pull/1943#discussion_r1038076604
########## zookeeper-server/src/test/java/org/apache/zookeeper/server/util/RateLimiterTest.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.zookeeper.server.util; + +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; +import java.util.concurrent.TimeUnit; +import org.junit.jupiter.api.Test; + +public class RateLimiterTest { + + @Test + public void testAllow_withinInterval() { + final int rate = 2; + final RateLimiter rateLimiter = new RateLimiter(rate, 5, TimeUnit.SECONDS); + for (int i = 0; i < rate; i++) { + assertTrue(rateLimiter.allow()); + } + assertFalse(rateLimiter.allow()); + } + + @Test + public void testAllow_exceedInterval() throws Exception { + final int interval = 1; + + final RateLimiter rateLimiter = new RateLimiter(1, interval, TimeUnit.SECONDS); + assertTrue(rateLimiter.allow()); + assertFalse(rateLimiter.allow()); + Thread.sleep(TimeUnit.SECONDS.toMillis(interval) + 1); Review Comment: Please wait 2 seconds at least. Thread.sleep() in tests could easly lead to flaky test. Additonally I think it would be nice to have a multithreaded test as well: start 10 worker in an executor to grab the numbers and verify that the 11th is disallowed within the time interval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
