eolivelli commented on PR #1947: URL: https://github.com/apache/zookeeper/pull/1947#issuecomment-1370997242
I would prefer to not commit the new constructor and then remove it. There is no hurry in committing a patch, and sometimes if someone adds a new API it may stay there forever if we forget about it. So overall I believe that it is better to add the builder and do not add a new public constructor.. For the test, we can a very simple test that bootstraps an instance using the new builder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
