anmolnar commented on code in PR #1961: URL: https://github.com/apache/zookeeper/pull/1961#discussion_r1065872646
########## zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java: ########## @@ -1151,6 +1213,9 @@ protected void setLocalSessionFlag(Request si) { } public void submitRequest(Request si) { + if (state == State.MAINTENANCE) { + throw new IllegalStateException("Zookeeper server is in maintenance state"); + } Review Comment: What are you thinking of exactly? We already block the thread when RequestThrottler or first processor is not yet initialized with the following logic: ```java while (state == State.INITIAL) { wait(1000); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org