kezhuw commented on PR #1978: URL: https://github.com/apache/zookeeper/pull/1978#issuecomment-1430656910
Hi @ztzg @eolivelli, thanks for reviewing. I think the purpose of this pr and #1559 are identical. Actually, the server part fixes are almost same. The `CreateOptions` in this pr was inspired by [kezhuw/zookeeper-rust-client](https://github.com/kezhuw/zookeeper-client-rust/blob/7466e867fb1b229d6b6ffb230e2e682c49ff494e/src/client/mod.rs#L109). I think it also suitable for java client to avoid massive overloading methods, not only `Op.create` but also `ZooKeeper.create`. I am kind of prefering `CreateOptions` over `CreateBuilder`. After read discussions in #1559, I split this pr into two commits: * The first bc645659934fedb267e16041aa6436b03d51bdef fixes server side support of `OpCode.create2` in `OpCode.multi`. It has no client side api changes except `Op.Create` for testing. * The second 59b499dacfbf375122280430a0acd262c4f66463 adds client side api to issue `OpCode.create2` in `OpCode.multi`. Look forward for further feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
