li4wang commented on code in PR #1966: URL: https://github.com/apache/zookeeper/pull/1966#discussion_r1116262437
########## zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java: ########## @@ -2069,7 +2069,7 @@ public void dumpMonitorValues(BiConsumer<String, Object> response) { /** * Grant or deny authorization to an operation on a node as a function of: - * @param cnxn : the server connection + * @param cnxn : the server connection or null for admin server commands Review Comment: Yes, you are right. the cnxn is not required, as the `serverObjs` is not used at all. We can clean it up separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org