tisonkun commented on code in PR #1984:
URL: https://github.com/apache/zookeeper/pull/1984#discussion_r1128826503
##########
zookeeper-contrib/zookeeper-contrib-monitoring/check_zookeeper.py:
##########
@@ -261,62 +256,21 @@ def _parse_stat(self, data):
result['zk_znode_count'] = int(m.group(1))
continue
- m = re.match('Watch count: (\d+)', line)
Review Comment:
I can approve the part of
* used 2to3 to make it work with Python 3.x
* loop to get all data in _send_cmd()
However, in the edge master branch, these matches are still
[there](https://github.com/apache/zookeeper/blob/14b936201b719ab5cf6346d1ed7dfc4ff382cbb7/zookeeper-contrib/zookeeper-contrib-monitoring/check_zookeeper.py#L226-L303).
So could you explain why you remove these lines?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
