tisonkun commented on code in PR #1893:
URL: https://github.com/apache/zookeeper/pull/1893#discussion_r1134920480
##########
zookeeper-client/zookeeper-client-c/tests/TestZookeeperInit.cc:
##########
@@ -90,6 +91,20 @@ class Zookeeper_init : public CPPUNIT_NS::TestFixture
#endif
}
+ void testVersion()
+ {
+ char EXPECTED_VERSION_STR[256];
+ EXPECTED_VERSION_STR[0] = 0;
+#ifdef ZOO_VERSION
+ snprintf(EXPECTED_VERSION_STR, sizeof(EXPECTED_VERSION_STR), "%s",
ZOO_VERSION);
+#endif
+#ifdef ZOO_VERSION_MAJOR
Review Comment:
Since the version macro change is introduced
https://github.com/apache/zookeeper/commit/253673f30431344030509b974bd2f65d23c1cd6e
in 3.6.0, I don't think we will do backport that needs this branch. That is,
we can retain only:
```c
snprintf(EXPECTED_VERSION_STR, sizeof(EXPECTED_VERSION_STR), "%s",
ZOO_VERSION);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
