[GitHub] [zookeeper] sonatype-lift[bot] commented on a diff in pull request #2030: ZOOKEEPER-4717: Cache serialize data in the request to avoid repeat serialize.

[via GitHub]

sonatype-lift[bot] commented on code in PR #2030:
URL: https://github.com/apache/zookeeper/pull/2030#discussion_r1255169583


##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java:
##########
@@ -1251,7 +1251,7 @@ public Proposal propose(Request request) throws 
XidRolloverException {
             throw new XidRolloverException(msg);
         }
 
-        byte[] data = SerializeUtils.serializeRequest(request);
+        byte[] data = request.getSerializeData();

Review Comment:
   <picture><img alt="7% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/7/display.svg";></picture>
   
   <b>*THREAD_SAFETY_VIOLATION:</b>*  Unprotected write. Non-private method 
`Leader.propose(...)` indirectly writes to field `request.serializeData` 
outside of synchronization.
    Reporting because this access may occur on a background thread.
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> 
commands</summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org