horizonzy commented on code in PR #2024:
URL: https://github.com/apache/zookeeper/pull/2024#discussion_r1264966905
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java:
##########
@@ -181,8 +182,7 @@ public byte[] getSerializeData() {
try {
this.serializeData = Util.marshallTxnEntry(this.hdr, this.txn,
this.txnDigest);
} catch (IOException e) {
- LOG.error("This really should be impossible.", e);
- this.serializeData = new byte[32];
+ throw new UncheckedIOException(e);
Review Comment:
Fine. I will push another pr to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
