kezhuw commented on code in PR #2043: URL: https://github.com/apache/zookeeper/pull/2043#discussion_r1295909476
########## zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java: ########## @@ -664,7 +664,7 @@ public long getLogDirSize() { if (zkDb == null) { return 0L; } - File path = zkDb.snapLog.getSnapDir(); + File path = zkDb.snapLog.getDataDir(); Review Comment: I think it is a good to rename `getDataDir` to something like `getLogDir` or `getDataLogDir`. I saw `dumpConf` prints it as `dataLogDir`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org