kezhuw commented on code in PR #2070:
URL: https://github.com/apache/zookeeper/pull/2070#discussion_r1338287108
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Follower.java:
##########
@@ -159,6 +159,22 @@ protected void processPacket(QuorumPacket qp) throws
Exception {
case Leader.PING:
ping(qp);
break;
+ case Leader.SKIP:
+ // It is sad that we have no breadcrumbs to route packet back to
origin. Basically, we have choices:
+ // 1. Attach breadcrumbs to outstanding request.
+ // This request protocol changes and protocol version bumping.
Review Comment:
I think we could also cover #2069 if we want to go this way. I prefer this
actually. We will inevitably introduce protocol changes in long term future. If
so, why now ? But it still could be a separate issue before 3.10.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
