kezhuw commented on PR #1988: URL: https://github.com/apache/zookeeper/pull/1988#issuecomment-1758870370
I was rethinking this in investigating ZOOKEEPER-4750. I think it might be more appropriate to throw error `UNIMPLEMENTED` for `OpCode.check` at the very first. `OpCode.check` was not designed to function individually and we have `OpCode.exists` already. Also, it might be distractive in metrics/logging(e.g. ZOOKEEPER-4750), as admins have to distinguish individual `OpCode.check` or transactional `OpCode.check` embedded inside `OpCode.multi`. I am sorry for the trouble. Any thoughts on this @tisonkun @anmolnar @eolivelli ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
