tisonkun commented on code in PR #2100:
URL: https://github.com/apache/zookeeper/pull/2100#discussion_r1435902913
##########
zookeeper-server/src/test/java/org/apache/zookeeper/server/CRCTest.java:
##########
@@ -102,8 +103,7 @@ private boolean getCheckSum(File snapFile) throws
IOException {
* @throws Exception
*/
@Test
- public void testChecksums() throws Exception {
- File tmpDir = ClientBase.createTmpDir();
+ public void testChecksums(@TempDir File tmpDir) throws Exception {
Review Comment:
This method has some issue on Windows but since we tests on *nix it should
be fine.
See https://github.com/junit-team/junit5/issues/2811 and so on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
