ctubbsii commented on PR #2098: URL: https://github.com/apache/zookeeper/pull/2098#issuecomment-1874706605
> For some reason I can not add reviewers @Iv9eni That's okay. You don't need to add reviewers. The creation of the PR will automatically notify the relevant people, based on their own notification settings. You don't usually need to tag anybody at all. And, it can backfire and annoy people by notifying them outside their own normal configuration settings, which can get spammy. For example, although I track what's going on in ZooKeeper, I'm not actually a committer... tagging me for a code review doesn't actually mean anything. I can't merge PRs or give any authoritative code review. I have no opinion to offer for this PR at all. So, I didn't need to be tagged. I don't know about the others, but they would have seen the PR whether or not they were tagged, if they are still following the project. So, you just didn't need to do it at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
