kezhuw commented on PR #1848: URL: https://github.com/apache/zookeeper/pull/1848#issuecomment-2003522895
This should be superceded by #2111. Both try to log diff entries synchronous before NEWLEADER ack and #2028 is similar. Additionally, #2111 should fix ZOOKEEPER-4643 also. I am not sure `testNormalFollowerRunWithDiff` is still flaky or not. I will check it later. No sure it is worth to revert it to pre ZOOKEEPER-2678 given my [comments](https://issues.apache.org/jira/browse/ZOOKEEPER-3023?focusedCommentId=17516241&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17516241) in ZOOKEEPER-3023. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
