jonmv opened a new pull request, #2154: URL: https://github.com/apache/zookeeper/pull/2154
This PR fixes the shutdown errors that were added in #157, and also avoids a common NPE during ZK shutdown from a learner, when the leader shuts down (first commit). Together with #2111 and #2152, this should cover all the fixes in #1925. We've had the forked ZK from #1925 running embedded in hundreds, if not thousands, of ZK clusters, with rolling restarts most days, and we've had zero cases of inconsistent data since we patched—one or a few cases per week before that. (We still sometimes see ephemeral nodes remain after the leader is brutally taken down, i.e., with `Runtime.halt()`, but this looks different; it seems clearing out client sessions, and their ephemeral nodes, simply isn't done when death is too sudden.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
