ctubbsii commented on code in PR #2155:
URL: https://github.com/apache/zookeeper/pull/2155#discussion_r1559893434
##########
zookeeper-assembly/pom.xml:
##########
@@ -103,6 +103,10 @@
<groupId>jline</groupId>
<artifactId>jline</artifactId>
</dependency>
+ <dependency>
+ <groupId>ch.qos.logback</groupId>
+ <artifactId>logback-classic</artifactId>
+ </dependency>
Review Comment:
By convention, Apache Accumulo marks all of its assembly dependencies as
"optional", just in case somebody actually depends on the tarball out of a
Maven repository, it won't resolve all the dependencies that were used to build
the tarball. We could have used "provided" instead for that purpose. But
ultimately, it doesn't matter if you're not publishing the assembly to Maven.
The conventions for dealing with assemblies in Maven repos kind of break all
the norms used for jars. Either way, everything bundled in the assembly should
be explicitly listed as a dependency, regardless of whatever other
scopes/modifiers you put on them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
