kezhuw commented on code in PR #2140: URL: https://github.com/apache/zookeeper/pull/2140#discussion_r1730668299
########## zookeeper-client/zookeeper-client-c/src/zookeeper.c: ########## @@ -5111,11 +5111,11 @@ int zoo_add_auth(zhandle_t *zh,const char* scheme,const char* cert, static const char* format_endpoint_info(const struct sockaddr_storage* ep) { - static char buf[134] = { 0 }; + static __thread char buf[134] = { 0 }; Review Comment: Do we need a macro here to accommodate single thread version and different compilers ? cc @ztzg -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org