purushah commented on PR #2178: URL: https://github.com/apache/zookeeper/pull/2178#issuecomment-2312781364
>My only concern is that changing the default behaviour is dangerous and it's not strictly necessary for this patch to work. I'd keep the original behaviour and parse as hours without a modifier. @anmolnar , just to clarify, we are not altering the original behavior. The getPurgeInterval() method is only used in DatadirCleanupManager.java. Could you please elaborate on your concerns? I feel like I might be missing something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
