kezhuw commented on code in PR #2058:
URL: https://github.com/apache/zookeeper/pull/2058#discussion_r1769468005
##########
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java:
##########
@@ -1274,7 +1295,6 @@ private void cleanAndNotifyState() {
eventThread.queueEvent(new WatchedEvent(Event.EventType.None,
Event.KeeperState.Disconnected, null));
Review Comment:
> We should not fire continuous disconnected event without a
`KeeperState.SyncConnected`.
This is not true. Currently, we are firing `KeeperState.Disconnected` after
every disconnection even for not established connection.
But it should not affect this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
