kezhuw commented on code in PR #2130:
URL: https://github.com/apache/zookeeper/pull/2130#discussion_r1772400231


##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java:
##########
@@ -92,9 +93,16 @@ public class ZKDatabase {
     public static final String COMMIT_LOG_COUNT = "zookeeper.commitLogCount";
     public static final int DEFAULT_COMMIT_LOG_COUNT = 500;
     public int commitLogCount;
+    public static final String COMMIT_LOG_SIZE = "zookeeper.commitLogSize";
+    public static final double DEFAULT_COMMIT_LOG_SIZE = 
Runtime.getRuntime().maxMemory() * 0.2;

Review Comment:
   Is it evaluated as bytes ? Should it better to be `long` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to