luozongle01 commented on PR #2206: URL: https://github.com/apache/zookeeper/pull/2206#issuecomment-2445635303
Hi, @kezhuw, I made some modifications, thank you for your review last time. I feel much better now than last time. I hope you can help me look again. Currently, multi-line comments and single-line comments are supported. I put `JField` or `JRecord` into a `TreeSet`, so that I can get the `line` or `column` information of the previous or next element. According to the `beginLine`, `beginColumn`, `endLine`, `endColumn` information, I determine the range of my comment area, and then format the output in line number order. Here is my testing process. 1. Verify that the modification only affects the comments and does not affect the normal code. 2. When verifying that each JField is on its own line, multi-line comments and single-line comments are generated normally. <img width="1317" alt="image" src="https://github.com/user-attachments/assets/28f797ca-f474-46d0-b178-f3a7abb5faf4";> <img width="1388" alt="image" src="https://github.com/user-attachments/assets/4e9fce69-3c38-4698-ac90-24882eea6196";> 3. If the attributes are on the same line, the comment should belong to the previous Field. <img width="1402" alt="image" src="https://github.com/user-attachments/assets/77120d53-9f8b-4323-9cad-485d58f97aef";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
