ctubbsii commented on PR #2216: URL: https://github.com/apache/zookeeper/pull/2216#issuecomment-2501492755
> Thanks @ctubbsii . lgtm, but I'd like to see what's @eolivelli 's opinion. I don't think this one requires much review... it's a pretty trivial change... but more importantly, it's a required change. Some of these v3 actions [will stop working soon](https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/) and ZK's builds will start breaking (actually, they won't run at all and will fail immediately while the yaml is being parsed). This specific PR is in response to INFRA's recent notice sent to projects who are still using v3 artifacts. Although only a few of the actions will be banned soon, the others will also eventually be banned, for being too old. In short: bumping the versions from v3 to v4 needs to be done. ZK doesn't have a choice here. The only thing optional in this PR is the change to use setup-java's language-specific cache mechanism for Maven, rather than using the low-level actions/cache, but I think that change is also pretty obvious and trivial and is [documented here](https://github.com/actions/setup-java?tab=readme-ov-file#caching-packages-dependencies). For context, I was the one who originally authored these files in d7ed7f305661c08927eb954700f7141cd18d4ff9 and was the one who introduced the old caching mechanism in these files. I have already migrated my own projects to use this new method to cache build dependencies. It's a much simpler config to maintain, and works just as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
