anmolnar commented on PR #2185: URL: https://github.com/apache/zookeeper/pull/2185#issuecomment-2555077971
> LGTM > > > it causes lock contention on the ZookeeperServer object with the sync operation. > > Does anyone have any cue about why `sync` get `synchronized` ? I saw that `sync` is called only in one thread and `pendingSyncs` is concurrent safe. I have no idea either. I think we could remove synchronize from `sync()` too. Or remove it only from `sync()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
