kezhuw commented on code in PR #2228: URL: https://github.com/apache/zookeeper/pull/2228#discussion_r1974830580
########## zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FastLeaderElection.java: ########## @@ -485,8 +485,8 @@ class WorkerSender extends ZooKeeperThread { volatile boolean stop; QuorumCnxManager manager; - WorkerSender(QuorumCnxManager manager) { - super("WorkerSender"); + WorkerSender(QuorumCnxManager manager, String threadName) { + super(threadName); Review Comment: How about change LOG.info("WorkerSender is down"); to LOG.info("{} is down", getName()); ? ########## zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FastLeaderElection.java: ########## @@ -223,8 +223,8 @@ class WorkerReceiver extends ZooKeeperThread { volatile boolean stop; QuorumCnxManager manager; - WorkerReceiver(QuorumCnxManager manager) { - super("WorkerReceiver"); + WorkerReceiver(QuorumCnxManager manager, String threadName) { + super(threadName); Review Comment: How about change `LOG.info("WorkerReceiver is down");` to `LOG.info("{} is down", getName());` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org