jjtt commented on code in PR #2230:
URL: https://github.com/apache/zookeeper/pull/2230#discussion_r1995117173
##########
zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java:
##########
@@ -1490,7 +1490,7 @@ public String create(
final String serverPath = prependChroot(clientPath);
RequestHeader h = new RequestHeader();
- setCreateHeader(createMode, h);
+ setCreateHeader(createMode, h, stat != null);
Create2Response response = new Create2Response();
Review Comment:
After staring at the code for a while I now think that my suggestion here is
not a realistic way forward.
Something like separate `create()` methods for using the different create
operations and then maybe a single higher level method that chooses which one
to use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
